Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: limit resize observer to width #3467

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Fix: limit resize observer to width #3467

merged 1 commit into from
Jan 4, 2024

Conversation

katspaugh
Copy link
Owner

Short description

Resolves #3465 and #3460

Implementation details

A resize observer on the scroll container could cause an undesired re-rendering of the waveform when the height of the container changes.

Copy link

cloudflare-workers-and-pages bot commented Jan 4, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6554753
Status: ✅  Deploy successful!
Preview URL: https://7193f9c1.wavesurfer-js.pages.dev
Branch Preview URL: https://resize.wavesurfer-js.pages.dev

View logs

Copy link
Contributor

github-actions bot commented Jan 4, 2024

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@katspaugh katspaugh force-pushed the resize branch 2 times, most recently from f1464a6 to 1383759 Compare January 4, 2024 20:35
@katspaugh katspaugh merged commit c741319 into main Jan 4, 2024
4 checks passed
@katspaugh katspaugh deleted the resize branch January 4, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rendering spectrogram / wave inside <tr><td> table
1 participant